Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/discrete_valuation_ring): add not_is_field #16979

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(ring_theory/discrete_valuation_ring): add not_is_field #16979

wants to merge 5 commits into from

Conversation

mariainesdff
Copy link
Collaborator

@mariainesdff mariainesdff commented Oct 14, 2022 •
edited

A discrete valuation ring is not a field.

Open in Gitpod

@mariainesdff mariainesdff added the awaiting-review The author would like community review of the PR label Oct 14, 2022
@joelriou
Copy link
Collaborator

I believe that this lemma not_is_field should be moved to ring_theory.discrete_valuation_ring just after the lemma not_a_field, because your proof generalises to any discrete valuation ring.

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 14, 2022
@mariainesdff
Copy link
Collaborator Author

I believe that this lemma not_is_field should be moved to ring_theory.discrete_valuation_ring just after the lemma not_a_field, because your proof generalises to any discrete valuation ring.

Good point, thanks!

@mariainesdff mariainesdff changed the title feat(number_theory/padics/padic_integers): add padic_int.not_is_field feat(ring_theory/discrete_valuation_ring): add not_is_field Oct 17, 2022
@mariainesdff mariainesdff added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 17, 2022
@alreadydone alreadydone added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 18, 2022
@alreadydone
Copy link
Collaborator

Thanks 🎉

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@ocfnash
Copy link
Collaborator

ocfnash commented Oct 19, 2022

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 19, 2022
bors bot pushed a commit that referenced this pull request Oct 19, 2022
@mariainesdff
feat(ring_theory/discrete_valuation_ring): add not_is_field (#16979)
7cc9c7a 
A discrete valuation ring is not a field.
@bors
Copy link

bors bot commented Oct 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/discrete_valuation_ring): add not_is_field [Merged by Bors] - feat(ring_theory/discrete_valuation_ring): add not_is_field Oct 19, 2022
@bors bors bot closed this Oct 19, 2022
@bors bors bot deleted the mariainesdff/padic_int_not_field branch October 19, 2022 19:11
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mariainesdff @joelriou @alreadydone @ocfnash @eric-wieser