Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/padics/padic_numbers): add is_fraction_ring instance #16981

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(number_theory/padics/padic_numbers): add is_fraction_ring instance #16981

wants to merge 1 commit into from

Conversation

mariainesdff
Copy link
Collaborator

ℚ_[p] is the fraction ring of ℤ_[p].

Open in Gitpod

@mariainesdff mariainesdff added WIP Work in progress awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 14, 2022
@mariainesdff mariainesdff added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 17, 2022
jcommelin
jcommelin approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 24, 2022
bors bot pushed a commit that referenced this pull request Oct 24, 2022
@mariainesdff
feat(number_theory/padics/padic_numbers): add is_fraction_ring instan…
082350f 
…ce (#16981)

`ℚ_[p]` is the fraction ring of `ℤ_[p]`.
@bors
Copy link

bors bot commented Oct 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/padics/padic_numbers): add is_fraction_ring instance [Merged by Bors] - feat(number_theory/padics/padic_numbers): add is_fraction_ring instance Oct 24, 2022
@bors bors bot closed this Oct 24, 2022
@bors bors bot deleted the mariainesdff/padic_fraction_ring branch October 24, 2022 10:35
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mariainesdff @jcommelin @eric-wieser @leanprover-community-bot-assistant