[Merged by Bors] - refactor(geometry/manifold/cont_mdiff): split everything about mfderiv #16982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
the
awaiting-CI
1 task
github-actions
bot
removed
the
awaiting-CI
fpvandoorn
added
t-differential-geometry
|
It builds, so I guess you haven't done anything silly :-) |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
#16982) * Remove import `mfderiv` from `cont_mdiff` * Separate everything about `mfderiv` and `mdifferentiable` to a separate file * The reason is that many properties about `mfderiv` are nicely proven once we already know about things like `cont_mdiff_fst` (unless we want to prove `mdifferentiable_fst` separately?) * We could also try to separate out `mdifferentiable` from `mfderiv`. However, this is harder, since proofs about `mdifferentiable` are given using `has_mfderiv_at` * Needed (sort-of) to port more results from the sphere eversion project.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mfderivfromcont_mdiffmfderivandmdifferentiableto a separate filemfderivare nicely proven once we already know about things likecont_mdiff_fst(unless we want to provemdifferentiable_fstseparately?)mdifferentiablefrommfderiv. However, this is harder, since proofs aboutmdifferentiableare given usinghas_mfderiv_at