Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/pnat): add missing norm_cast attributes #16995

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/pnat): add missing norm_cast attributes #16995

wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Oct 14, 2022 •
edited

Also renames nat.primes.coe_[p]nat_inj to nat.primes.coe_[p]nat_injective to match the naming guide, and make room for the iff version occupying the original name.

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 16, 2022
@eric-wieser eric-wieser added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Oct 16, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Oct 25, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 25, 2022
bors bot pushed a commit that referenced this pull request Oct 25, 2022
@eric-wieser
feat(data/pnat): add missing norm_cast attributes (#16995)
0d58044 
Also renames `nat.primes.coe_[p]nat_inj` to `nat.primes.coe_[p]nat_injective` to match the naming guide, and make room for the `iff` version occupying the original name.
@bors
Copy link

bors bot commented Oct 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/pnat): add missing norm_cast attributes [Merged by Bors] - feat(data/pnat): add missing norm_cast attributes Oct 25, 2022
@bors bors bot closed this Oct 25, 2022
@bors bors bot deleted the eric-wieser/pnat-norm_cast branch October 25, 2022 13:23
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @ocfnash