Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/derivation): A presentation of the Kähler differential module #17011

Closed
wants to merge 8 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 16, 2022

We add an alternative description of Ω[S⁄R], presenting it as S copies of S with kernel generated by the relations:

  1. dx + dy = d(x + y)
  2. x dy + y dx = d(x * y)
  3. dr = 0 for r ∈ R

Open in Gitpod

@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Oct 16, 2022
@riccardobrasca riccardobrasca self-assigned this Nov 14, 2022
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some docstring? Also, it would be nice to have a final theorem, saying that the Kähler differential module is isomorphic to S →₀ S / ker_total. The best way to state this would be to prove that it satisfies the universal property, but I am not sure we have it. In any case, the final result should be added as a "main result" at the beginning of the file.

src/ring_theory/derivation.lean Outdated Show resolved Hide resolved
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add a TODO saying that we want a characteristic predicate is_kaehler_differential (the universal property) and the fact that the two (isomorphic) modules satisfy it. I am afraid we will suffer if we do things for a particular definition.

Also, can you please add a description of the PR?

← linear_map.map_smul_of_tower, finsupp.smul_single, mul_comm, algebra.smul_def],
end

/-- (Implementation) An auxiliary definition for `kaehler_differential.ker_total_eq`. -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an implementation detail: it is the universal derivation after all (if this were the definition of Kaehler differential)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the intended way to use this result is to treat Ω[S⁄R] as the quotient (using total_surjective and ker_total) instead of reasoning with the quotient module and then transferring the result using an equivalence; not least because the "transferring" part is math-trivial but (usually) lean-tedious.
That said, there is an argument to be made that we (being a library) should provide all things we could, and let the user decide how they would like to use them.

src/ring_theory/derivation.lean Show resolved Hide resolved
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 15, 2022
bors bot pushed a commit that referenced this pull request Nov 15, 2022
…al module (#17011)

We add an alternative description of `Ω[S⁄R]`, presenting it as `S` copies of `S` with kernel generated by the relations:
1. `dx + dy = d(x + y)`
2. `x dy + y dx = d(x * y)`
3. `dr = 0` for `r ∈ R` 



Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/derivation): A presentation of the Kähler differential module [Merged by Bors] - feat(ring_theory/derivation): A presentation of the Kähler differential module Nov 15, 2022
@bors bors bot closed this Nov 15, 2022
@bors bors bot deleted the kaehler_differential_presentation branch November 15, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants