Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/measure/measure_space): volume_preimage_coe #17030

Closed
wants to merge 2 commits into from

Conversation

alexjbest
Copy link
Member

This is another lemma needed by #2819, I'm not sure exactly of its provenance, but it looks like @YaelDillies extracted it as a lemma at least, if not wrote the original version completely.

Co-authored-by: Yaël Dillies yael.dillies@gmail.com


Open in Gitpod

@alexjbest alexjbest added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 17, 2022
@alexjbest alexjbest requested a review from a team as a code owner October 17, 2022 12:45
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 17, 2022
@fpvandoorn
Copy link
Member

This is not the right generality. We want to prove lemmas first for a variable measure μ.
Note that the volume on a subtype is defined as measure.comap subtype.val volume, so the lemma for variable measures can mention measure.comap subtype.val μ, but then you can probably also generalize subtype.val to get a general lemma about measure.comap.

@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 17, 2022
@RemyDegenne RemyDegenne added the t-measure-probability Measure theory / Probability theory label Oct 27, 2022
@YaelDillies
Copy link
Collaborator

YaelDillies commented Nov 4, 2022

@fpvandoorn, are you sure? The current proof crucially relies on measurable_set.null_measurable_set_subtype_coe and subtype.range_coe, which don't have general comap analogs. Here's the best I could do

@[simp] lemma comap_preimage [measurable_space β] {μ : measure α} {s : set α} {f : β → α}
  (hf : injective f) (hf' : measurable f)
  (h : ∀ t, measurable_set t → null_measurable_set (f '' t) μ) (hs : measurable_set s) :
  μ.comap f (f ⁻¹' s) = μ (s ∩ range f) :=
by rw [comap_apply₀ _ _ hf h (hf' hs).null_measurable_set, image_preimage_eq_inter_range]

@[simp] lemma volume_preimage_coe {s t : set α} (hs : null_measurable_set s)
  (ht : measurable_set t) : volume ((coe : s → α) ⁻¹' t) = volume (t ∩ s) :=
by rw [volume_set_coe_def, comap_preimage subtype.coe_injective measurable_subtype_coe
  (by rwa subtype.range_coe) (λ h, measurable_set.null_measurable_set_subtype_coe hs) ht,
  subtype.range_coe]

The assumptions look very unnatural and the actual lemma is not even shorter 😢

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 4, 2022
@urkud
Copy link
Member

urkud commented Nov 5, 2022

In comap_preimage, you can get hfμ from h unit. This assumption holds, e.g., for any https://leanprover-community.github.io/mathlib_docs/measure_theory/measurable_space.html#measurable_embedding

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 5, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 6, 2022
@YaelDillies YaelDillies changed the title feat(measure_theory/measure/measure_space): add volume_preimage_coe feat(measure_theory/measure/measure_space): volume_preimage_coe Nov 11, 2022
@fpvandoorn
Copy link
Member

Thanks for adding the other versions!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 11, 2022
bors bot pushed a commit that referenced this pull request Nov 11, 2022
…7030)

This is another lemma needed by #2819, I'm not sure exactly of its provenance, but it looks like @YaelDillies extracted it as a lemma at least, if not wrote the original version completely.

Co-authored-by: Yaël Dillies [yael.dillies@gmail.com](mailto:yael.dillies@gmail.com)



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Nov 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/measure/measure_space): volume_preimage_coe [Merged by Bors] - feat(measure_theory/measure/measure_space): volume_preimage_coe Nov 12, 2022
@bors bors bot closed this Nov 12, 2022
@bors bors bot deleted the alexjbest/volume_preimage_coe branch November 12, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants