Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): consistently use R[X] notation for polynomials #17044

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - chore(*): consistently use R[X] notation for polynomials #17044

wants to merge 12 commits into from

Conversation

semorrison
Copy link
Collaborator

Consistently use R[X] in favour of polynomial R. The exceptions that I've left as is are the cases where R itself includes an identifier or more brackets.

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Oct 18, 2022
@semorrison semorrison requested a review from a team as a code owner October 18, 2022 10:00
@Vierkantor Vierkantor self-assigned this Oct 19, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 27, 2022
@urkud
Copy link
Member

urkud commented Oct 29, 2022

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 29, 2022
bors bot pushed a commit that referenced this pull request Oct 29, 2022
@semorrison
chore(*): consistently use R[X] notation for polynomials (#17044)
62c0a4e 
Consistently use `R[X]` in favour of `polynomial R`. The exceptions that I've left as is are the cases where `R` itself includes an identifier or more brackets.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 30, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): consistently use R[X] notation for polynomials [Merged by Bors] - chore(*): consistently use R[X] notation for polynomials Oct 30, 2022
@bors bors bot closed this Oct 30, 2022
@bors bors bot deleted the semorrison/polynomial_notation branch October 30, 2022 02:00
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vierkantor Vierkantor

Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @urkud @eric-wieser @Vierkantor