Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/set/basic): symm_diff lemmas #17051

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

A few lemma about symm_diff, and their translation to set.


From Con(NF)

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Oct 18, 2022
h.le_symm_diff_sup_symm_diff_right

@[simp] lemma symm_diff_nonempty : (s ∆ t).nonempty ↔ s ≠ t :=
ne_empty_iff_nonempty.symm.trans symm_diff_eq_bot.not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should symm_diff_eq_bot be duplicated as symm_diff_eq_empty?

@@ -1584,12 +1596,19 @@ begin
exact image_subset f (subset_union_right t s)
end

lemma subset_image_symm_diff : (f '' s) ∆ (f '' t) ⊆ f '' s ∆ t :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma subset_image_symm_diff : (f '' s) ∆ (f '' t) ⊆ f '' s ∆ t :=
lemma subset_image_symm_diff {f : α → β} : (f '' s) ∆ (f '' t) ⊆ f '' s ∆ t :=

to match all the other nearby lemmas.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label Oct 18, 2022
@bors
Copy link

bors bot commented Oct 18, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the awaiting-review The author would like community review of the PR label Oct 18, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 29, 2022
A few lemma about `symm_diff`, and their translation to `set`.
@bors
Copy link

bors bot commented Oct 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/basic): symm_diff lemmas [Merged by Bors] - feat(data/set/basic): symm_diff lemmas Oct 29, 2022
@bors bors bot closed this Oct 29, 2022
@bors bors bot deleted the image_symm_diff branch October 29, 2022 09:38
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants