Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(combinatorics/young): define list of row lengths of a Young diagram #17061

Closed
wants to merge 5 commits into from

Conversation

jakelev
Copy link
Collaborator

@jakelev jakelev commented Oct 19, 2022

Define row_lens : list ℕ, the list of row lengths of a Young diagram and prove it is weakly decreasing and positive.

This is the first half of the equivalence young_diagram ≃ {w : list ℕ // w.sorted (≥) ∧ ∀ x ∈ w, 0 < x}.


The rest of the equivalence will be established in a separate PR.

The fact that list.range n is a sorted list seems worth having in mathlib but I'm not sure where it would go. In the list namespace?

Open in Gitpod

@jakelev jakelev requested a review from a team as a code owner October 19, 2022 05:34
@alreadydone alreadydone added awaiting-review The author would like community review of the PR t-combinatorics Combinatorics labels Oct 19, 2022
src/combinatorics/young/young_diagram.lean Outdated Show resolved Hide resolved

-/

-- This belongs somewhere in the list namespace. Is it already in mathlib?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the best would be in data/list/range.lean, but if list.sorted isn't avaliable there, perhaps put these in data/list/sort.lean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it: there is list.pairwise_lt_range but no list.pairwise_le_range. Adding it seems to mean all of mathlib has to be recompiled (since list is so basic). Is there a way to speed it up?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make the change, then push a commit to your branch; CI will run on it, and when it is done you can use leanproject get-cache to download the compiled oleans.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

src/combinatorics/young/young_diagram.lean Outdated Show resolved Hide resolved
src/combinatorics/young/young_diagram.lean Outdated Show resolved Hide resolved
src/combinatorics/young/young_diagram.lean Outdated Show resolved Hide resolved
src/combinatorics/young/young_diagram.lean Outdated Show resolved Hide resolved
@kmill kmill added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 27, 2022
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@jakelev jakelev added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 5, 2022
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 5, 2022
@jakelev jakelev added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 8, 2022
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 8, 2022
bors bot pushed a commit that referenced this pull request Nov 8, 2022
…ram (#17061)

Define `row_lens : list ℕ`, the list of row lengths of a Young diagram and prove it is weakly decreasing and positive.

This is the first half of the equivalence `young_diagram ≃ {w : list ℕ // w.sorted (≥) ∧ ∀ x ∈ w, 0 < x}`.
@bors
Copy link

bors bot commented Nov 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(combinatorics/young): define list of row lengths of a Young diagram [Merged by Bors] - feat(combinatorics/young): define list of row lengths of a Young diagram Nov 8, 2022
@bors bors bot closed this Nov 8, 2022
@bors bors bot deleted the jlev_young_diagrams_row_lens branch November 8, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants