[Merged by Bors] - refactor(geometry/euclidean/oriented_angle): split file #17134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `geometry.euclidean.oriented_angle` up into `geometry.euclidean.angle.oriented.basic`, `geometry.euclidean.angle.oriented.affine` and `geometry.euclidean.angle.sphere` (the last only has a few results at present but is intended to get a lot more, both oriented results and unoriented results deduced from the oriented ones). --- Whichever PR of this one and #17094 goes in first, the other will then need a minor update (since that PR modifies proofs that this PR moves to a different file).
|
Are there any API/proof changes in this PR? If no, then |
|
✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
There are no API or proof changes. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2022
Split `geometry.euclidean.oriented_angle` up into `geometry.euclidean.angle.oriented.basic`, `geometry.euclidean.angle.oriented.affine` and `geometry.euclidean.angle.sphere` (the last only has a few results at present but is intended to get a lot more, both oriented results and unoriented results deduced from the oriented ones).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
geometry.euclidean.oriented_angleup intogeometry.euclidean.angle.oriented.basic,geometry.euclidean.angle.oriented.affineandgeometry.euclidean.angle.sphere(the last only has a few results at present but is intended to get a lot more, both oriented results and unoriented results deduced from the oriented ones).Whichever PR of this one and #17094 goes in first, the other will then need a minor update (since that PR modifies proofs that this PR moves to a different file).