fix(tactic/polyrith): fix crash when hypotheses are constant polynomials #17142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for the case when there are no variables, by working around a bug in Sage.
|
I'll label this as |
semorrison
added
the
not-too-late
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 9, 2023
It does, I just made a PR to fix it. |
eric-wieser
added
the
awaiting-review
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 18, 2023
…als (#7586) This forward-ports leanprover-community/mathlib#17142 The tests are commented out because the test framework for polyrith was never ported. You can check out the branch and run polyrith manually to see that everything is ok.
|
Closing since this was fixed in leanprover-community/mathlib4#7586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without adding
P()to the constaints, we end up with2 : builtins.intinstead of2 : sage.SomePolynomialType, and things only go downhill from there.Also adds support for the case when there are no variables, by working around a bug in Sage where 0-variate polynomials fail to interface with the "Singular" C library correctly; the workaround is to just introduce a dummy variable.
Closes #17141
This came up on the Xena discord.