Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(topology/sheaf_condition): is_sheaf_iff_pairwise_intersections without products #17181

Closed
wants to merge 2 commits into from

Conversation

alreadydone
Copy link
Collaborator

  • Generalize universes in category_theory/limits/final in order to generalize universe in is_sheaf_opens_le_cover_iff_is_sheaf_pairwise_intersections, from which we deduce is_sheaf_iff_is_sheaf_pairwise_intersection in full generality; the original version of this lemma with a has_products assumption now has ' appended to its name, and will be removed in a future refactor.

  • As applications, we remove has_products from the definition of the pushforward functor in topology/sheaves/functors (and generalize universes there), and from skyscraper sheaves.


Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebraic-geometry Algebraic geometry labels Oct 26, 2022
@alreadydone alreadydone requested review from jjaassoonn and a team October 26, 2022 04:16
@alreadydone alreadydone requested a review from a team as a code owner October 26, 2022 04:16
@alreadydone alreadydone removed the request for review from a team October 26, 2022 04:16
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 26, 2022
@erdOne
Copy link
Member

erdOne commented Oct 27, 2022

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 27, 2022
bors bot pushed a commit that referenced this pull request Oct 27, 2022
…without products (#17181)

+ Generalize universes in *category_theory/limits/final* in order to generalize universe in `is_sheaf_opens_le_cover_iff_is_sheaf_pairwise_intersections`, from which we deduce `is_sheaf_iff_is_sheaf_pairwise_intersection` in full generality; the original version of this lemma with a `has_products` assumption now has `'` appended to its name, and will be removed in a future refactor.

+ As applications, we remove `has_products` from the definition of the pushforward functor in *topology/sheaves/functors* (and generalize universes there), and from skyscraper sheaves.
@bors
Copy link

bors bot commented Oct 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/sheaf_condition): is_sheaf_iff_pairwise_intersections without products [Merged by Bors] - chore(topology/sheaf_condition): is_sheaf_iff_pairwise_intersections without products Oct 27, 2022
@bors bors bot closed this Oct 27, 2022
@bors bors bot deleted the pairwise_intersections_has_products branch October 27, 2022 10:46
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants