Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/star/basic): basic lemmas for star_ordered_ring #17218

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(algebra/star/basic): basic lemmas for star_ordered_ring #17218

wants to merge 5 commits into from

Conversation

j-loreaux
Copy link
Collaborator

Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc) labels Oct 28, 2022
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 28, 2022
@j-loreaux @ADedecker
Update src/algebra/star/basic.lean
aa7c508 
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 28, 2022
@ADedecker
Copy link
Member

Thanks!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by ADedecker.

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@bors
Copy link

bors bot commented Oct 28, 2022

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 28, 2022
@j-loreaux
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 28, 2022
@j-loreaux
feat(algebra/star/basic): basic lemmas for star_ordered_ring (#17218)
27ac3e1
@bors
Copy link

bors bot commented Oct 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/star/basic): basic lemmas for star_ordered_ring [Merged by Bors] - feat(algebra/star/basic): basic lemmas for star_ordered_ring Oct 28, 2022
@bors bors bot closed this Oct 28, 2022
@bors bors bot deleted the j-loreaux/star-ordered-ring-lemmas branch October 28, 2022 23:56
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker ADedecker left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j-loreaux @ADedecker @riccardobrasca @eric-wieser