Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/commutator): Define the set of commutators #17276

Closed
wants to merge 4 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Oct 30, 2022

With some of my upcoming group theory PRs, it is going to start being helpful to have a name for the set of commutators.


Open in Gitpod

@tb65536 tb65536 added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Oct 30, 2022
@erdOne
Copy link
Member

erdOne commented Oct 31, 2022

LGTM
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@kmill
Copy link
Collaborator

kmill commented Nov 1, 2022

I see you made a couple small changes to a proof or two, so out of caution I'll delegate merging to you.

bors d+

@bors
Copy link

bors bot commented Nov 1, 2022

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 1, 2022
@tb65536
Copy link
Collaborator Author

tb65536 commented Nov 1, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2022
With some of my upcoming group theory PRs, it is going to start being helpful to have a name for the set of commutators.
@bors
Copy link

bors bot commented Nov 1, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 1, 2022
With some of my upcoming group theory PRs, it is going to start being helpful to have a name for the set of commutators.
@bors
Copy link

bors bot commented Nov 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/commutator): Define the set of commutators [Merged by Bors] - feat(group_theory/commutator): Define the set of commutators Nov 1, 2022
@bors bors bot closed this Nov 1, 2022
@bors bors bot deleted the tb_commutators branch November 1, 2022 19:25
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants