Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(geometry/euclidean/angle/sphere): affine circle theorems #17279

Closed
wants to merge 1 commit into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Oct 30, 2022

Add (oriented) Euclidean affine space versions of "angle at center of a circle equals twice angle at circumference" and "angles in same segment are equal" / "opposite angles of a cyclic quadrilateral add to π" (which were previously only present for angles between vectors, not for angles between points in an oriented Euclidean affine space).


I intend to add many more such lemmas in due course (including converses and unoriented angle versions); this is just a starting point with affine versions of the same lemmas we already have for angles between vectors.


Open in Gitpod

Add (oriented) Euclidean affine space versions of "angle at center of
a circle equals twice angle at circumference" and "angles in same
segment are equal" / "opposite angles of a cyclic quadrilateral add to
π" (which were previously only present for angles between vectors, not
for angles between points in an oriented Euclidean affine space).

---

I intend to add many more such lemmas in due course (including
converses and unoriented angle versions); this is just a starting
point with affine versions of the same lemmas we already have for
angles between vectors.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Oct 30, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Nov 22, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 22, 2022
bors bot pushed a commit that referenced this pull request Nov 22, 2022
Add (oriented) Euclidean affine space versions of "angle at center of a circle equals twice angle at circumference" and "angles in same segment are equal" / "opposite angles of a cyclic quadrilateral add to π" (which were previously only present for angles between vectors, not for angles between points in an oriented Euclidean affine space).
@bors
Copy link

bors bot commented Nov 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry/euclidean/angle/sphere): affine circle theorems [Merged by Bors] - feat(geometry/euclidean/angle/sphere): affine circle theorems Nov 22, 2022
@bors bors bot closed this Nov 22, 2022
@bors bors bot deleted the jsm28/oangle_sphere_affine branch November 22, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants