Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finset/basic): add lemmas about filter and (co)disjoint #17296

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/finset/basic): add lemmas about filter and (co)disjoint #17296

wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 1, 2022 •
edited

This generalizes finset.filter_inter_filter_neg_eq to when the sets are different, and then further to when the propositions are not complementary but only disjoint.

A similar story is true of the union lemma.

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-order Order hierarchy labels Nov 1, 2022
@eric-wieser eric-wieser force-pushed the eric-wieser/filter-disjoint-lemmas branch from bd44f53 to c1e8d1b Compare November 1, 2022 09:29
YaelDillies
YaelDillies approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks!

maintainer merge

@eric-wieser eric-wieser requested a review from a team as a code owner November 1, 2022 13:47
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 2, 2022
@eric-wieser eric-wieser mentioned this pull request Nov 2, 2022
Closed
2 tasks
jcommelin
jcommelin approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 5, 2022
bors bot pushed a commit that referenced this pull request Nov 5, 2022
@eric-wieser
feat(data/finset/basic): add lemmas about filter and (co)disjoint (#1…
7951ed3 
…7296)

This generalizes `finset.filter_inter_filter_neg_eq` to when the sets are different, and then further to when the propositions are not complementary but only disjoint.

A similar story is true of the `union` lemma.
@bors
Copy link

bors bot commented Nov 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finset/basic): add lemmas about filter and (co)disjoint [Merged by Bors] - feat(data/finset/basic): add lemmas about filter and (co)disjoint Nov 5, 2022
@bors bors bot closed this Nov 5, 2022
@bors bors bot deleted the eric-wieser/filter-disjoint-lemmas branch November 5, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eric-wieser @jcommelin @YaelDillies @leanprover-community-bot-assistant