[Merged by Bors] - feat(analysis/normed/group/add_circle): results about finite-order points on the circle #17321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints on the circle
ocfnash
added
awaiting-review
Hoping to fix a deterministic timeout unrelated to my work
4 tasks
j-loreaux
reviewed
Nov 11, 2022
j-loreaux
added
awaiting-author
The number of lines changed is slightly higher than it might be because I have also flipped the order of arguments in `gcd n m` to `gcd m n`. This is to be compatible with `rat.cop` which became relevant in view of the new lemma `add_circle.add_order_of_coe_rat`.
ocfnash
added
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
eric-wieser
reviewed
Nov 15, 2022
* Renaming: use `nat_cast` instead of `coe` in various places * Add lemma `fract_div_int_cast_eq_div_int_cast_mod` supporting `int`
eric-wieser
reviewed
Nov 16, 2022
eric-wieser
reviewed
Nov 16, 2022
eric-wieser
reviewed
Nov 16, 2022
eric-wieser
reviewed
Nov 18, 2022
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
github-actions
bot
removed
the
awaiting-review
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
…ints on the circle (#17321) The main motivation for developing this API is the lemma `add_circle.le_add_order_smul_norm_of_is_of_fin_add_order` Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for developing this API is the lemma
add_circle.le_add_order_smul_norm_of_is_of_fin_add_order