[Merged by Bors] - chore(data/finsupp/defs): redefine finsupp.single as pi.single
#17356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also brings it in line with `dfinsupp.single`. Note that the two are still not defeq due to different decidability instances, but things are least more consistent now.
1 task
eric-wieser
added
awaiting-review
eric-wieser
force-pushed
the
eric-wieser/fix-finsupp-single-small
branch
from
7384025
to
f8b8078
Compare
github-actions
bot
removed
the
awaiting-CI
Vierkantor
approved these changes
Nov 10, 2022
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
…17356) This also brings it in line with `dfinsupp.single`. Note that the two are still not defeq due to different decidability instances, but things are least more consistent now. In order to make some proofs still unify, this makes some type arguments explicit to `constant_coeff_C` and `constant_coeff_X`. These lemmas should have had these as explicit arguments anyway, as the type can't be inferred from the other arguments.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
finsupp.single as pi.singlefinsupp.single as pi.single
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also brings it in line with
dfinsupp.single.Note that the two are still not defeq due to different decidability instances, but things are least more consistent now.
In order to make some proofs still unify, this makes some type arguments explicit to
constant_coeff_Candconstant_coeff_X. These lemmas should have had these as explicit arguments anyway, as the type can't be inferred from the other arguments.