Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(analysis/convex/strict): rename, golf, generalize #17464

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 10, 2022

  • rename convex.strict_convex to convex.strict_convex_of_open;
  • prove set.ord_connected.strict_convex;
  • use it to prove strict_convex_Ixx and golf strict_convex_iff_convex.

Open in Gitpod

* rename `convex.strict_convex` to `convex.strict_convex_of_open`;
* prove `set.ord_connected.strict_convex`;
* use it to prove `strict_convex_Ixx` and golf `strict_convex_iff_convex`.
@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-analysis Analysis (normed *, calculus) labels Nov 10, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

lemma strict_convex_Ioo (r s : β) : strict_convex 𝕜 (Ioo r s) := ord_connected_Ioo.strict_convex
lemma strict_convex_Ico (r s : β) : strict_convex 𝕜 (Ico r s) := ord_connected_Ico.strict_convex
lemma strict_convex_Ioc (r s : β) : strict_convex 𝕜 (Ioc r s) := ord_connected_Ioc.strict_convex
lemma strict_convex_interval (r s : β) : strict_convex 𝕜 (interval r s) := strict_convex_Icc _ _

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

1 similar comment
@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 11, 2022
bors bot pushed a commit that referenced this pull request Nov 11, 2022
* rename `convex.strict_convex` to `convex.strict_convex_of_open`;
* prove `set.ord_connected.strict_convex`;
* use it to prove `strict_convex_Ixx` and golf `strict_convex_iff_convex`.
bors bot pushed a commit that referenced this pull request Nov 11, 2022
* rename `convex.strict_convex` to `convex.strict_convex_of_open`;
* prove `set.ord_connected.strict_convex`;
* use it to prove `strict_convex_Ixx` and golf `strict_convex_iff_convex`.
@bors
Copy link

bors bot commented Nov 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(analysis/convex/strict): rename, golf, generalize [Merged by Bors] - refactor(analysis/convex/strict): rename, golf, generalize Nov 11, 2022
@bors bors bot closed this Nov 11, 2022
@bors bors bot deleted the YK-convex-golf branch November 11, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants