[Merged by Bors] - chore(algebra/algebra): reduce imports for algebra.algebra.tower
#17476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
awaiting-review
2 tasks
This splits `algebra.algebra.tower` into three files: `algebra.algebra.tower.basic`, `algebra.algebra.tower.bilinear` and `algebra.algebra.subalgebra.tower`
Vierkantor
force-pushed
the
split-algebra-tower
branch
from
0a78344
to
31d24e3
Compare
github-actions
bot
removed
the
awaiting-CI
sgouezel
reviewed
Nov 14, 2022
sgouezel
added
awaiting-author
This rename is unneeded now that the other files in that folder have been moved out.
Vierkantor
added
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
…17476) This splits `algebra.algebra.tower` into two files: `algebra.algebra.tower.basic` and `algebra.algebra.subalgebra.tower`. The motivation behind this PR is that `algebra.algebra.tower` is a relatively fundamental and popular file to import (especially since it used to contain `is_scalar_tower`), but its import tree also includes relatively complicated files such as `ring_theory.ideal.operations`. By splitting off these less popular dependencies we can save quite a bit of complexity in the import graph. Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
algebra.algebra.toweralgebra.algebra.tower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
algebra.algebra.towerinto two files:algebra.algebra.tower.basicandalgebra.algebra.subalgebra.tower.The motivation behind this PR is that
algebra.algebra.toweris a relatively fundamental and popular file to import (especially since it used to containis_scalar_tower), but its import tree also includes relatively complicated files such asring_theory.ideal.operations. By splitting off these less popular dependencies we can save quite a bit of complexity in the import graph.