New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/ne_zero): generalize lemmas #17477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negiizhao
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
t-algebra
Algebra (groups, rings, fields etc)
labels
Nov 11, 2022
1 task
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Nov 11, 2022
negiizhao
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 12, 2022
negiizhao
changed the title
feat(algebra/ne_zero): generalizing lemmas
feat(algebra/ne_zero): generalize lemmas
Nov 12, 2022
semorrison
reviewed
Nov 13, 2022
semorrison
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 13, 2022
negiizhao
added
help-wanted
The author needs attention to resolve issues
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
help-wanted
The author needs attention to resolve issues
labels
Nov 14, 2022
negiizhao
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Nov 14, 2022
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Nov 14, 2022
semorrison
reviewed
Nov 14, 2022
Can you please fix the conflict? |
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 16, 2022
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
Lemmas with reduced typeclass assumptions: `zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one` Removed lemmas: `is_R_or_C.two_ne_zero` `two_ne_zero'` New explicit version lemmas: `zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'` Renamed lemma: `ne_zero.ne'` -> `ne_zero.nat_cast_ne` New lemma: `ne_zero.ne'` Most of other diffs are just simply replace `@lemma` with new explicit lemmas mathlib4: leanprover-community/mathlib4#577
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
Lemmas with reduced typeclass assumptions: `zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one` Removed lemmas: `is_R_or_C.two_ne_zero` `two_ne_zero'` New explicit version lemmas: `zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'` Renamed lemma: `ne_zero.ne'` -> `ne_zero.nat_cast_ne` New lemma: `ne_zero.ne'` Most of other diffs are just simply replace `@lemma` with new explicit lemmas mathlib4: leanprover-community/mathlib4#577
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
Lemmas with reduced typeclass assumptions: `zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one` Removed lemmas: `is_R_or_C.two_ne_zero` `two_ne_zero'` New explicit version lemmas: `zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'` Renamed lemma: `ne_zero.ne'` -> `ne_zero.nat_cast_ne` New lemma: `ne_zero.ne'` Most of other diffs are just simply replace `@lemma` with new explicit lemmas mathlib4: leanprover-community/mathlib4#577
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(algebra/ne_zero): generalize lemmas
[Merged by Bors] - feat(algebra/ne_zero): generalize lemmas
Nov 17, 2022
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
t-algebra
Algebra (groups, rings, fields etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmas with reduced typeclass assumptions:
zero_ne_one
one_ne_zero
two_ne_zero
three_ne_zero
four_ne_zero
ne_zero_of_eq_one
Removed lemmas:
is_R_or_C.two_ne_zero
two_ne_zero'
New explicit version lemmas:
zero_ne_one'
one_ne_zero'
two_ne_zero'
three_ne_zero'
four_ne_zero'
Renamed lemma:
ne_zero.ne'
->ne_zero.nat_cast_ne
New lemma:
ne_zero.ne'
Most of other diffs are just simply replace
@lemma
with new explicit lemmasmathlib4: leanprover-community/mathlib4#577