Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/ne_zero): generalize lemmas #17477

Closed
wants to merge 20 commits into from

Conversation

negiizhao
Copy link
Collaborator

@negiizhao negiizhao commented Nov 11, 2022

Lemmas with reduced typeclass assumptions:
zero_ne_one one_ne_zero two_ne_zero three_ne_zero four_ne_zero ne_zero_of_eq_one

Removed lemmas:
is_R_or_C.two_ne_zero two_ne_zero'

New explicit version lemmas:
zero_ne_one' one_ne_zero' two_ne_zero' three_ne_zero' four_ne_zero'

Renamed lemma:
ne_zero.ne' -> ne_zero.nat_cast_ne

New lemma:
ne_zero.ne'

Most of other diffs are just simply replace @lemma with new explicit lemmas

mathlib4: leanprover-community/mathlib4#577


Open in Gitpod

@negiizhao negiizhao added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Nov 11, 2022
@negiizhao negiizhao requested review from a team as code owners November 11, 2022 14:39
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 11, 2022
negiizhao added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 12, 2022
@negiizhao negiizhao changed the title feat(algebra/ne_zero): generalizing lemmas feat(algebra/ne_zero): generalize lemmas Nov 12, 2022
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 13, 2022
@negiizhao negiizhao added help-wanted The author needs attention to resolve issues awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-author A reviewer has asked the author a question or requested changes help-wanted The author needs attention to resolve issues labels Nov 14, 2022
@negiizhao negiizhao added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 14, 2022
@riccardobrasca
Copy link
Member

Can you please fix the conflict?

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 16, 2022
bors bot pushed a commit that referenced this pull request Nov 17, 2022
Lemmas with reduced typeclass assumptions:
`zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one`

Removed lemmas:
`is_R_or_C.two_ne_zero` `two_ne_zero'`

New explicit version lemmas:
`zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'`

Renamed lemma:
`ne_zero.ne'` -> `ne_zero.nat_cast_ne`

New lemma:
`ne_zero.ne'`

Most of other diffs are just simply replace `@lemma` with new explicit lemmas

mathlib4: leanprover-community/mathlib4#577
bors bot pushed a commit that referenced this pull request Nov 17, 2022
Lemmas with reduced typeclass assumptions:
`zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one`

Removed lemmas:
`is_R_or_C.two_ne_zero` `two_ne_zero'`

New explicit version lemmas:
`zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'`

Renamed lemma:
`ne_zero.ne'` -> `ne_zero.nat_cast_ne`

New lemma:
`ne_zero.ne'`

Most of other diffs are just simply replace `@lemma` with new explicit lemmas

mathlib4: leanprover-community/mathlib4#577
bors bot pushed a commit that referenced this pull request Nov 17, 2022
Lemmas with reduced typeclass assumptions:
`zero_ne_one` `one_ne_zero` `two_ne_zero` `three_ne_zero` `four_ne_zero` `ne_zero_of_eq_one`

Removed lemmas:
`is_R_or_C.two_ne_zero` `two_ne_zero'`

New explicit version lemmas:
`zero_ne_one'` `one_ne_zero'` `two_ne_zero'` `three_ne_zero'` `four_ne_zero'`

Renamed lemma:
`ne_zero.ne'` -> `ne_zero.nat_cast_ne`

New lemma:
`ne_zero.ne'`

Most of other diffs are just simply replace `@lemma` with new explicit lemmas

mathlib4: leanprover-community/mathlib4#577
@bors
Copy link

bors bot commented Nov 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ne_zero): generalize lemmas [Merged by Bors] - feat(algebra/ne_zero): generalize lemmas Nov 17, 2022
@bors bors bot closed this Nov 17, 2022
@bors bors bot deleted the FR_zero_ne_one branch November 17, 2022 10:56
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants