Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(topology/algebra/order/basic): move field-parts into new file #17549

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(topology/algebra/order/basic): move field-parts into new file #17549

wants to merge 4 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Nov 15, 2022 •
edited

@mcdoll mcdoll added the WIP Work in progress label Nov 15, 2022
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Nov 15, 2022
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 15, 2022
YaelDillies
YaelDillies reviewed Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not used to the Android app not submitting my review automatically.

src/topology/algebra/order/field.lean
# Topologies on linear ordered fields

-/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/topology/algebra/order/field.lean

/-!
# Topologies on linear ordered fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand a bit?

bors bot pushed a commit that referenced this pull request Nov 15, 2022
@mcdoll
chore(topology/algebra/order/basic): move field-parts into new file (#…
f5ea01f 
…17549)

File authorship credits go to:
* Benjamin Davidson: #4138
* Devon Tuma: #7545
* Eric Rodriguez: #15022
* Oliver Nash: #16762
@bors
Copy link

bors bot commented Nov 15, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 16, 2022
@mcdoll
chore(topology/algebra/order/basic): move field-parts into new file (#…
49ae0e3 
…17549)

File authorship credits go to:
* Benjamin Davidson: #4138
* Devon Tuma: #7545
* Eric Rodriguez: #15022
* Oliver Nash: #16762
@bors
Copy link

bors bot commented Nov 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/algebra/order/basic): move field-parts into new file [Merged by Bors] - chore(topology/algebra/order/basic): move field-parts into new file Nov 16, 2022
@bors bors bot closed this Nov 16, 2022
@bors bors bot deleted the mcdoll/split_1 branch November 16, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdoll @sgouezel @YaelDillies