[Merged by Bors] - chore(topology/{fiber,vector}_bundle/*): reorganize files #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
hrmacbeth
added
the
awaiting-review
|
LGTM bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
The PR #17505 was a big refactor but left declarations in place. This PR proposes a reorganization to clean up: - new file `topology.fiber_bundle.is_homeomorphic_trivial_bundle` for the legacy `is_homeomorphic_trivial_fiber_bundle` construction (see [discussion](#17505 (comment))) - new file `topology.fiber_bundle.constructions` covering the trivial, fibrewise-product and pullback fiber bundles. The trivial-bundle material was previously split between `topology.{fiber,vector}_bundle.basic`, the prod material was previously in `topology.vector_bundle.prod`, the pullback material was previously in `topology.vector_bundle.pullback` - new file `topology.vector_bundle.constructions` covering the trivial, direct-sum and pullback vector bundles. The trivial-bundle material was previously in `topology.vector_bundle.basic`, the prod material was previously in `topology.vector_bundle.prod`, the pullback material was previously in `topology.vector_bundle.pullback` - delete files `topology.vector_bundle.prod` and `topology.vector_bundle.pullback`, whose material has all been moved elsewhere - delete construction `trivialization.comap`, which was morally (though not literally) a duplicate of `trivialization.pullback` - cleaner proof of `trivialization.prod.open_source`, removing a spurious dependence on an ambient fiber bundle structure - updated and augmented docs
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #17505 was a big refactor but left declarations in place. This PR proposes a reorganization to clean up:
topology.fiber_bundle.is_homeomorphic_trivial_bundlefor the legacyis_homeomorphic_trivial_fiber_bundleconstruction (see discussion)topology.fiber_bundle.constructionscovering the trivial, fibrewise-product and pullback fiber bundles. The trivial-bundle material was previously split betweentopology.{fiber,vector}_bundle.basic, the prod material was previously intopology.vector_bundle.prod, the pullback material was previously intopology.vector_bundle.pullbacktopology.vector_bundle.constructionscovering the trivial, direct-sum and pullback vector bundles. The trivial-bundle material was previously intopology.vector_bundle.basic, the prod material was previously intopology.vector_bundle.prod, the pullback material was previously intopology.vector_bundle.pullbacktopology.vector_bundle.prodandtopology.vector_bundle.pullback, whose material has all been moved elsewheretrivialization.comap, which was morally (though not literally) a duplicate oftrivialization.pullbacktrivialization.prod.open_source, removing a spurious dependence on an ambient fiber bundle structure