Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data/list/*): Reduce imports #17574

Closed
wants to merge 14 commits into from
Closed

Conversation

YaelDillies
Copy link
Collaborator

Strategically move lemmas around to significantly reduce dependencies on the algebraic order hierarchy for list files.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Nov 16, 2022
src/data/int/range.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Nov 18, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 18, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 19, 2022
Strategically move lemmas around to significantly reduce dependencies on the algebraic order hierarchy for `list` files.
@bors
Copy link

bors bot commented Nov 19, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 19, 2022
Strategically move lemmas around to significantly reduce dependencies on the algebraic order hierarchy for `list` files.
@bors
Copy link

bors bot commented Nov 19, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 19, 2022
Strategically move lemmas around to significantly reduce dependencies on the algebraic order hierarchy for `list` files.
@bors
Copy link

bors bot commented Nov 19, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 19, 2022
Strategically move lemmas around to significantly reduce dependencies on the algebraic order hierarchy for `list` files.
@bors
Copy link

bors bot commented Nov 19, 2022

Build failed:

@YaelDillies
Copy link
Collaborator Author

@semorrison, do you still think this PR is worth doing? The imports for data.list.big_operators.basic got down by quite a lot since I opened this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants