[Merged by Bors] - refactor(data/fintype/basic): split file #17578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
semorrison
commented
Nov 17, 2022
semorrison
commented
semorrison
added
the
awaiting-CI
eric-wieser
reviewed
Nov 17, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison
added
the
awaiting-review
|
LGTM bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Oh I had an almost ready split. |
YaelDillies
reviewed
Nov 17, 2022
Comment on lines
+10
to
+12
| /-! | ||
| # fintype instances for sigma types | ||
| -/ |
There was a problem hiding this comment.
There's an argument that those structure files should be merged with the corresponding ones under finset. The ones under finset are basically only imported by the fintype ones, and they are a continuation of each other.
|
I've now run the linter and tests locally, so let's try: bors merge |
github-actions
bot
added
the
ready-to-merge
|
bors merge |
|
👎 Rejected by label |
semorrison
removed
the
awaiting-CI
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.