Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/cubic_discriminant): add eq_zero and ne_zero lemmas #17627

Closed
wants to merge 2 commits into from

Conversation

Multramate
Copy link
Collaborator

E.g. to allow degree_of_c_eq_zero' instead of degree_of_c_eq_zero rfl rfl rfl when the cubic is known to be constant.


Open in Gitpod

@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Nov 19, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 19, 2022
@riccardobrasca riccardobrasca self-assigned this Nov 23, 2022
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 24, 2022
bors bot pushed a commit that referenced this pull request Nov 24, 2022
)

E.g. to allow `degree_of_c_eq_zero'` instead of `degree_of_c_eq_zero rfl rfl rfl` when the cubic is known to be constant.
@bors
Copy link

bors bot commented Nov 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/cubic_discriminant): add eq_zero and ne_zero lemmas [Merged by Bors] - feat(algebra/cubic_discriminant): add eq_zero and ne_zero lemmas Nov 24, 2022
@bors bors bot closed this Nov 24, 2022
@bors bors bot deleted the cubic_discriminant branch November 24, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants