Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/with_bot): add nat.with_bot.add_eq_iff lemmas #17629

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/nat/with_bot): add nat.with_bot.add_eq_iff lemmas #17629

wants to merge 3 commits into from

Conversation

Multramate
Copy link
Collaborator

Open in Gitpod

@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 19, 2022
@Multramate Multramate mentioned this pull request Nov 19, 2022
Closed
4 tasks
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 19, 2022
@Multramate Multramate added the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 24, 2022
tb65536
tb65536 approved these changes Nov 24, 2022
View reviewed changes
src/data/nat/order/basic.lean Outdated Show resolved Hide resolved
src/data/nat/with_bot.lean Outdated Show resolved Hide resolved
src/data/nat/with_bot.lean Outdated Show resolved Hide resolved
@tb65536 tb65536 added awaiting-author A reviewer has asked the author a question or requested changes and removed easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Nov 24, 2022
@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 24, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 24, 2022
@tb65536
Copy link
Collaborator

tb65536 commented Nov 25, 2022

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by tb65536.

riccardobrasca
riccardobrasca approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just remove the duplicate lemma? Thanks!

bors d+

src/data/nat/with_bot.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 25, 2022

✌️ Multramate can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 25, 2022
@riccardobrasca
Copy link
Member

Oh sorry, you're moving it. Then

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 25, 2022
bors bot pushed a commit that referenced this pull request Nov 25, 2022
@Multramate
feat(data/nat/with_bot): add nat.with_bot.add_eq_iff lemmas (#17629)
f717251
@bors
Copy link

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/with_bot): add nat.with_bot.add_eq_iff lemmas [Merged by Bors] - feat(data/nat/with_bot): add nat.with_bot.add_eq_iff lemmas Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the add_eq_iff branch November 25, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tb65536 tb65536 tb65536 approved these changes

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Multramate @tb65536 @riccardobrasca @leanprover-community-bot-assistant