Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/subgroup/basic): weaken some TC assumptions #17698

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 23, 2022

  • Add to_additive to units.coe_to_hom_units.
  • Assume that the codomain is a mul_one_class instead of a group in monoid_hom.eq_iff, monoid_hom.ker_one, monoid_hom.ker_eq_bot_iff, and monoid_hom.normal_ker.
  • Add monoid_hom.ker_cod_restrict, rename monoid_hom.range_restrict_ker to monoid_hom.ker_range_restrict.
  • Golf some proofs.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Nov 23, 2022
@Vierkantor Vierkantor self-assigned this Nov 24, 2022
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/group_theory/subgroup/basic.lean Show resolved Hide resolved
src/group_theory/subgroup/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 24, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 24, 2022
urkud and others added 3 commits November 24, 2022 10:44
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@urkud
Copy link
Member Author

urkud commented Nov 24, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 24, 2022
bors bot pushed a commit that referenced this pull request Nov 24, 2022
* Add `to_additive` to `units.coe_to_hom_units`.
* Assume that the codomain is a `mul_one_class` instead of a `group` in `monoid_hom.eq_iff`, `monoid_hom.ker_one`, `monoid_hom.ker_eq_bot_iff`, and `monoid_hom.normal_ker`.
* Add `monoid_hom.ker_cod_restrict`, rename `monoid_hom.range_restrict_ker` to `monoid_hom.ker_range_restrict`.
* Golf some proofs.
@bors
Copy link

bors bot commented Nov 25, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Nov 25, 2022
* Add `to_additive` to `units.coe_to_hom_units`.
* Assume that the codomain is a `mul_one_class` instead of a `group` in `monoid_hom.eq_iff`, `monoid_hom.ker_one`, `monoid_hom.ker_eq_bot_iff`, and `monoid_hom.normal_ker`.
* Add `monoid_hom.ker_cod_restrict`, rename `monoid_hom.range_restrict_ker` to `monoid_hom.ker_range_restrict`.
* Golf some proofs.
@bors
Copy link

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/subgroup/basic): weaken some TC assumptions [Merged by Bors] - feat(group_theory/subgroup/basic): weaken some TC assumptions Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the YK-group-monoid branch November 25, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants