New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(group_theory/subgroup/basic): weaken some TC assumptions #17698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
bors merge |
* Add `to_additive` to `units.coe_to_hom_units`. * Assume that the codomain is a `mul_one_class` instead of a `group` in `monoid_hom.eq_iff`, `monoid_hom.ker_one`, `monoid_hom.ker_eq_bot_iff`, and `monoid_hom.normal_ker`. * Add `monoid_hom.ker_cod_restrict`, rename `monoid_hom.range_restrict_ker` to `monoid_hom.ker_range_restrict`. * Golf some proofs.
This PR was included in a batch that was canceled, it will be automatically retried |
* Add `to_additive` to `units.coe_to_hom_units`. * Assume that the codomain is a `mul_one_class` instead of a `group` in `monoid_hom.eq_iff`, `monoid_hom.ker_one`, `monoid_hom.ker_eq_bot_iff`, and `monoid_hom.normal_ker`. * Add `monoid_hom.ker_cod_restrict`, rename `monoid_hom.range_restrict_ker` to `monoid_hom.ker_range_restrict`. * Golf some proofs.
Pull request successfully merged into master. Build succeeded: |
to_additive
tounits.coe_to_hom_units
.mul_one_class
instead of agroup
inmonoid_hom.eq_iff
,monoid_hom.ker_one
,monoid_hom.ker_eq_bot_iff
, andmonoid_hom.normal_ker
.monoid_hom.ker_cod_restrict
, renamemonoid_hom.range_restrict_ker
tomonoid_hom.ker_range_restrict
.