Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/quot,data/set/basic): add lemmas about lift #17699

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 23, 2022

  • Add quot.surjective_lift, quotient.surjective_lift_on'.
  • Mark quot.lift_mk as simp.
  • Add set.range_quot_lift, set.range_quotient_lift, set.range_quotient_mk', and set.range_quotient_lift_on'.
  • The mathlib4 version: [Merged by Bors] - feat(Data/Quot): add 2 lemmas mathlib4#701.
  • Prove matrix.to_linear_map₂_apply by rfl.

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Nov 23, 2022
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2022
* Add `Quot.surjective_lift` and `Quotient.surjective_liftOn'`.
* This is the `mathlib4` version of leanprover-community/mathlib#17699.
src/data/quot.lean Outdated Show resolved Hide resolved
src/data/set/basic.lean Outdated Show resolved Hide resolved
src/data/set/basic.lean Outdated Show resolved Hide resolved
Comment on lines 318 to 323
begin
rw [matrix.to_linear_map₂, linear_map.to_matrix₂, linear_equiv.symm_trans_apply,
←matrix.to_linear_map₂'],
simp [matrix.to_linear_map₂'_apply],
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either mention this in the PR description or remove it from the PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended as a fixup to #17705?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've got a timeout and fixed it.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link

bors bot commented Nov 24, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 24, 2022
@urkud
Copy link
Member Author

urkud commented Nov 24, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 24, 2022
bors bot pushed a commit that referenced this pull request Nov 24, 2022
* Add `quot.surjective_lift`, `quotient.surjective_lift_on'`.
* Mark `quot.lift_mk` as `simp`.
* Add `set.range_quot_lift`, `set.range_quotient_lift`, `set.range_quotient_mk'`, and `set.range_quotient_lift_on'`.
* The `mathlib4` version: leanprover-community/mathlib4#701.
* Prove `matrix.to_linear_map₂_apply` by `rfl`.
@bors
Copy link

bors bot commented Nov 25, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Nov 25, 2022
* Add `quot.surjective_lift`, `quotient.surjective_lift_on'`.
* Mark `quot.lift_mk` as `simp`.
* Add `set.range_quot_lift`, `set.range_quotient_lift`, `set.range_quotient_mk'`, and `set.range_quotient_lift_on'`.
* The `mathlib4` version: leanprover-community/mathlib4#701.
* Prove `matrix.to_linear_map₂_apply` by `rfl`.
@bors
Copy link

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/quot,data/set/basic): add lemmas about lift [Merged by Bors] - feat(data/quot,data/set/basic): add lemmas about lift Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the YK-range-lift branch November 25, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants