Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/support): golf, use to_additive #17711

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(algebra/support): golf, use to_additive #17711

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 24, 2022

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Nov 24, 2022
riccardobrasca
riccardobrasca approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/algebra/support.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 25, 2022

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 25, 2022
@urkud
Copy link
Member Author

urkud commented Nov 25, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 25, 2022
bors bot pushed a commit that referenced this pull request Nov 25, 2022
@urkud
chore(algebra/support): golf, use to_additive (#17711)
44e2d1e
@bors
Copy link

bors bot commented Nov 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/support): golf, use to_additive [Merged by Bors] - chore(algebra/support): golf, use to_additive Nov 26, 2022
@bors bors bot closed this Nov 26, 2022
@bors bors bot deleted the YK-support-golf branch November 26, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @riccardobrasca @leanprover-community-bot-assistant