Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finsupp/defs): add map_range_neg and map_range_sub #17717

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(data/finsupp/defs): add map_range_neg and map_range_sub #17717

wants to merge 7 commits into from

Conversation

Multramate
Copy link
Collaborator

Open in Gitpod

@Multramate Multramate added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Nov 25, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Nov 25, 2022
@Multramate
Copy link
Collaborator Author

After some experimentation I'm not sure whether we should have neg_zero_class or sub_neg_zero_monoid instead of just add_group everywhere. On one hand I thought generalising the typeclasses would be good, but on the other hand I want to do things like map_range_sub (map_sub ...) but neither of those work anyway, and I'm really not understanding why.

eric-wieser
eric-wieser reviewed Nov 27, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sold on these primed versions; can we add them in a separate PR? b52fc37 looked ready to go to me.

@Multramate Multramate mentioned this pull request Nov 27, 2022
Closed
1 task
eric-wieser
eric-wieser approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Let's wait for CI just to be sure.

Would be nice to make the same generalizations for dfinsupp, but not necessary in this PR.

@bors
Copy link

bors bot commented Nov 27, 2022

✌️ Multramate can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 27, 2022
@Multramate
Copy link
Collaborator Author

bors r+

1 similar comment
@Multramate
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 27, 2022
@Multramate
feat(data/finsupp/defs): add map_range_neg and map_range_sub (#17717)
0f601d0
@bors
Copy link

bors bot commented Nov 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finsupp/defs): add map_range_neg and map_range_sub [Merged by Bors] - feat(data/finsupp/defs): add map_range_neg and map_range_sub Nov 27, 2022
@bors bors bot closed this Nov 27, 2022
@bors bors bot deleted the finsupp.map_range branch November 27, 2022 20:33
bors bot pushed a commit that referenced this pull request Jan 5, 2023
@Multramate @eric-wieser
feat(data/finsupp/defs): add add_monoid_hom_class versions of map_ran…
3c71503 
…ge (#17738)

- [x] depends on: #17717 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Multramate @eric-wieser @leanprover-community-bot-assistant