[Merged by Bors] - chore(order/bounded_order): split #17730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuzzard
added
the
awaiting-review
kbuzzard
removed
the
awaiting-review
|
I've just noticed the mathlib4 PR leanprover-community/mathlib4#697 which ports all of this file, so my motivation to split it has now gone away. Edit: I've now noticed that the PR is WIP and only ports the first quarter of this file, so splitting is now again perhaps a good idea (perhaps an even better idea, because it means that we'll easily be able to port one of the four files completely now, rather than 1/4-porting a too-long file) |
kbuzzard
added
the
awaiting-review
|
bors merge p=10 |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2022
The file `order.bounded_order` was over 2000 lines long and I wanted to port a small part of it in the middle so I've broken it into four files `order.bounded_order`, `order.with_bot`, `order.prop_instances` and `order.disjoint`. No lemmas should have been added or removed. Because `order.bounded_order` contains less than before I had to add a few more imports to other files.
2 tasks
|
bors merge |
1 similar comment
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2022
The file `order.bounded_order` was over 2000 lines long and I wanted to port a small part of it in the middle so I've broken it into four files `order.bounded_order`, `order.with_bot`, `order.prop_instances` and `order.disjoint`. No lemmas should have been added or removed. Because `order.bounded_order` contains less than before I had to add a few more imports to other files.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2022
- [x] depends on: #642 - [x] depends on: leanprover-community/mathlib#17730 Tracking mathlib commit: [e50b8c261b0a000b806ec0e1356b41945eda61f7](leanprover-community/mathlib@e50b8c2) Co-authored-by: David Wärn <codwarn@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
order.bounded_orderwas over 2000 lines long and I wanted to port a small part of it in the middle so I've broken it into four filesorder.bounded_order,order.with_bot,order.prop_instancesandorder.disjoint. No lemmas should have been added or removed. Becauseorder.bounded_ordercontains less than before I had to add a few more imports to other files.