[Merged by Bors] - chore(algebra/char_zero): split #17760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
awaiting-CI
|
bors d+ |
|
✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
@semorrison I fixed a timing-out calc block in the tests by breaking the calc into two. I hope this still tests what it's supposed to (it's in |
hrmacbeth
added
awaiting-review
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
Split `algebra/char_zero` into `algebra/char_zero/lemmas` and `algebra/char_zero/infinite` (there was already a `algebra/char_zero/defs`), with the former not importing finset.
As intended, this caused a few files which had been getting their finset import by this path to require that import explicitly. I've added the finset imports explicitly on all such files, except for `tactic/positivity`, the point being that I actually want to remove the finset import from positivity. I moved the `fin{set,type}.card` positivity extensions from `tactic/positivity` to `data/fintype/card`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
algebra/char_zerointoalgebra/char_zero/lemmasandalgebra/char_zero/infinite(there was already aalgebra/char_zero/defs), with the former not importing finset.As intended, this caused a few files which had been getting their finset import by this path to require that import explicitly. I've added the finset imports explicitly on all such files, except for
tactic/positivity, the point being that I actually want to remove the finset import from positivity. I moved thefin{set,type}.cardpositivity extensions fromtactic/positivitytodata/fintype/card.