[Merged by Bors] - refactor(data/set/intervals): Generalize set.interval to lattices
#17776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
eric-wieser
reviewed
Dec 1, 2022
eric-wieser
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Dec 12, 2022
eric-wieser
added
awaiting-author
YaelDillies
added
awaiting-review
eric-wieser
reviewed
Dec 12, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors d+ |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
…17776) Replace ``` def interval (a b : α) := Icc (min a b) (max a b) ``` by ``` def interval (a b : α) := Icc (a ⊓ b) (a ⊔ b) ``` Generalize lemmas accordingly.
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
…17776) Replace ``` def interval (a b : α) := Icc (min a b) (max a b) ``` by ``` def interval (a b : α) := Icc (a ⊓ b) (a ⊔ b) ``` Generalize lemmas accordingly.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
set.interval to latticesset.interval to lattices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
by
Generalize lemmas accordingly.
This might seem like a weird generality to have, but I actually need it (for
finset, precisely). See this proof of the van den Berg-Kesten-Reimer inequality on page 2.