[Merged by Bors] - refactor(algebra/group_ring_action): split out subobject actions #17786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
eric-wieser
force-pushed
the
split_group_ring_action
branch
from
d649158
to
b7d6d8d
Compare
eric-wieser
force-pushed
the
split_group_ring_action
branch
from
b7d6d8d
to
d631abb
Compare
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
) This moves: * Instances for `submonoid` and `subgroup` to a new `algebra.group_ring_action.subobjects` module * Instances for `subsemiring` and `subring` inline with the other smul instances * `invariant_subring` to its own file The argument goes that `mul_semiring_action` is just `mul_distrib_mul_action` + `ring`, so should be available as early as possible in the import hierarchy where both are already available. Cutting out subobject dependencies makes this easier.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves:
submonoidandsubgroupto a newalgebra.group_ring_action.subobjectsmodulesubsemiringandsubringinline with the other smul instancesinvariant_subringto its own fileThe argument goes that
mul_semiring_actionis justmul_distrib_mul_action+ring, so should be available as early as possible in the import hierarchy where both are already available. Cutting out subobject dependencies makes this easier.