Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/order/group/defs): split file #17787

Closed
wants to merge 10 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Dec 2, 2022

Splits:

  • algebra/order/group/defs.lean
  • algebra/group/with_one.lean
  • algebra/order/monoid/with_zero.lean

This will get us unstuck on the mathlib4 port, moving some of the files (about algebraic morphisms and equivalences) that are currently waiting for fixes in Lean 4 off the critical path.


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Dec 2, 2022
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Dec 2, 2022

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 2, 2022
@semorrison
Copy link
Collaborator Author

bors p=10

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 2, 2022
bors bot pushed a commit that referenced this pull request Dec 2, 2022
Splits:
* algebra/order/group/defs.lean
* algebra/group/with_one.lean
* algebra/order/monoid/with_zero.lean

This will get us unstuck on the mathlib4 port, moving some of the files (about algebraic morphisms and equivalences) that are currently waiting for fixes in Lean 4 off the critical path.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Dec 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/group/defs): split file [Merged by Bors] - chore(algebra/order/group/defs): split file Dec 2, 2022
@bors bors bot closed this Dec 2, 2022
@bors bors bot deleted the order_group_split branch December 2, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants