[Merged by Bors] - chore(number_theory/padics): fix lemma names and golf #17798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
easy
Closed
2 tasks
eric-wieser
added
the
t-number-theory
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
The `norm_p_pow` lemma was actually a lemma about `zpow`. This renames it add adds the missing lemma about pow. This also uses a nicer algebra instance that agrees with the subring definition, although it probably doesn't matter anywhere.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
norm_p_powlemma was actually a lemma aboutzpow. This renames it add adds the missing lemma about pow.This also uses a nicer algebra instance that agrees with the subring definition, although it probably doesn't matter anywhere.