feat(data/set/basic): more lemmas about set.nonempty
#1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this on master (and solve the conflict) so that seeing the additions of this PR becomes easier? Thanks! |
|
@sgouezel Done. |
jcommelin
added
the
ready-to-merge
jcommelin
approved these changes
Dec 5, 2019
fpvandoorn
reviewed
Dec 5, 2019
src/data/set/basic.lean
Outdated
| theorem insert_ne_empty (a : α) (s : set α) : insert a s ≠ ∅ := | ||
| by safe [ext_iff, iff_def]; have h' := a_1 a; finish | ||
| (insert_nonempty).ne_empty |
There was a problem hiding this comment.
This fix was lost while git rebaseing. That's one of the reasons I'd prefer if mathlib did proper git merge instead of squashing the history (then git merge would work).
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…mmunity#1780) * feat(data/set/basic): more lemmas about `set.nonempty` * Fix compile
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…mmunity#1780) * feat(data/set/basic): more lemmas about `set.nonempty` * Fix compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lemmas missing in #1779
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list