Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/module/big_operators): Product of sums #17818

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/module/big_operators): Product of sums #17818

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 5, 2022 •
edited

A few missing lemmas. finset.sum_smul_sum matches finset.sum_mul_sum.

Unrelatingly, fix the copyright after the split in #17764. I list as authors:

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 5, 2022
@YaelDillies YaelDillies mentioned this pull request Dec 5, 2022
Closed
4 tasks
eric-wieser
eric-wieser approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

Can you make it a little clearer in the PR description that you're modifying the copyright for an unrelated reason (a previous split?), and preferably include the PR that did the split too.

@bors
Copy link

bors bot commented Dec 10, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 10, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 10, 2022
@YaelDillies
feat(algebra/module/big_operators): Product of sums (#17818)
4e87c84 
A few missing lemmas. `finset.sum_smul_sum` matches `finset.sum_mul_sum`.

Unrelatingly, fix the copyright after the split in #17764. I list as authors:
* Chris for #327
* Yury for #1910
* myself for this PR
@bors
Copy link

bors bot commented Dec 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/module/big_operators): Product of sums [Merged by Bors] - feat(algebra/module/big_operators): Product of sums Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
@bors bors bot deleted the sum_smul_sum branch December 11, 2022 01:41
@YaelDillies YaelDillies mentioned this pull request Dec 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @eric-wieser @leanprover-community-bot-assistant