Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(group_theory/quotient_group): drop unneeded names in to_additive #17821

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(group_theory/quotient_group): drop unneeded names in to_additive #17821

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 5, 2022

This only changes the names of group and comm_group instances.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 5, 2022
@eric-wieser
Copy link
Member

I thought to_additive emitted warnings when this happened. Why were they not firing?

@urkud
Copy link
Member Author

urkud commented Dec 6, 2022

It doesn't work if the explicitly provided name has ..

jcommelin
jcommelin approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 6, 2022
bors bot pushed a commit that referenced this pull request Dec 6, 2022
@urkud
chore(group_theory/quotient_group): drop unneeded names in `to_additi…
0d17cfb 
…ve` (#17821)

This only changes the names of `group` and `comm_group` instances.
@bors
Copy link

bors bot commented Dec 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/quotient_group): drop unneeded names in to_additive [Merged by Bors] - chore(group_theory/quotient_group): drop unneeded names in to_additive Dec 6, 2022
@bors bors bot closed this Dec 6, 2022
@bors bors bot deleted the YK-quot-to-add branch December 6, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @eric-wieser @jcommelin @leanprover-community-bot-assistant