-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/normed/group/seminorm): add nonarchimedean (semi)norms #17851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having all those instances from nonarch_group_seminorm_class
, could you make nonarch_add_group_seminorm_class.to_add_group_seminorm_class
the first one you prove? Then you don't need any other.
Else my comments are mostly details!
Should I move |
Up to you, but I did the move only because we wanted to instantiate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking into account the various comments LGTM, thanks!
bors d+
✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with |
I am happy with it now, so feel free to merge! |
bors r+ |
…17851) We introduce nonarchimedean seminorms and norms on additive groups. Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
Build failed (retrying...): |
…17851) We introduce nonarchimedean seminorms and norms on additive groups. Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
Build failed (retrying...): |
…17851) We introduce nonarchimedean seminorms and norms on additive groups. Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
We introduce nonarchimedean seminorms and norms on additive groups.