Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed/group/seminorm): add nonarchimedean (semi)norms #17851

Closed
wants to merge 10 commits into from

Conversation

mariainesdff
Copy link
Collaborator

We introduce nonarchimedean seminorms and norms on additive groups.


Open in Gitpod

@mariainesdff mariainesdff added the awaiting-review The author would like community review of the PR label Dec 8, 2022
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having all those instances from nonarch_group_seminorm_class, could you make nonarch_add_group_seminorm_class.to_add_group_seminorm_class the first one you prove? Then you don't need any other.

Else my comments are mostly details!

src/analysis/normed/group/seminorm.lean Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Show resolved Hide resolved
@mariainesdff
Copy link
Collaborator Author

Should I move nonarch_add_group_(semi)norm_class to algebra.order.hom.basic? Since that's where the other norm classes are now.

src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator

Up to you, but I did the move only because we wanted to instantiate mul_ring_norm_class (absolute_value α β) α β without importing in algebra.order.absolute_value. I cannot see a similar justification for nonarch_add_group_seminorm.

@riccardobrasca riccardobrasca self-assigned this Jan 12, 2023
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking into account the various comments LGTM, thanks!

bors d+

src/analysis/normed/group/seminorm.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 12, 2023

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 12, 2023
@YaelDillies
Copy link
Collaborator

I am happy with it now, so feel free to merge!

@mariainesdff
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 13, 2023
…17851)

We introduce nonarchimedean seminorms and norms on additive groups.



Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 13, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 14, 2023
…17851)

We introduce nonarchimedean seminorms and norms on additive groups.



Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 14, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 14, 2023
…17851)

We introduce nonarchimedean seminorms and norms on additive groups.



Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 14, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed/group/seminorm): add nonarchimedean (semi)norms [Merged by Bors] - feat(analysis/normed/group/seminorm): add nonarchimedean (semi)norms Jan 14, 2023
@bors bors bot closed this Jan 14, 2023
@bors bors bot deleted the mariainesdff/nonarch_norms branch January 14, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants