-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(data/multiset/nodup): remove dependency on multiset.powerset
#17888
Conversation
What's the motivation for this move? It's not clear to me that either of Of course, if you wrote a PR description explaining your motivation you might be able to persuade me otherwise :) |
|
Ah thanks; finset needs nodup but not powerset. I think this change makes sense; can you fix the build failure? |
I've copy-edited your PR description to emphasize the important bits. Can you add a |
multiset.powerset
bors d+ Thanks! |
✌️ negiizhao can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Can you add a comment to that effect above the |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors r+ |
…17888) This flips the import direction between `data.multiset.powerset` and `data.multiset.nodup`, such that the former now imports the latter, moving lemmas as necessary. This matches how `data.list.sublists` (transitively) imports `data.list.nodup`. More importantly, this means that `finset` (which needs `multiset.nodup`) can be defined without needing the material on `list.sublists` and `multiset.powerset`.
Pull request successfully merged into master. Build succeeded: |
multiset.powerset
multiset.powerset
This flips the import direction between
data.multiset.powerset
anddata.multiset.nodup
, such that the former now imports the latter, moving lemmas as necessary.This matches how
data.list.sublists
(transitively) importsdata.list.nodup
.More importantly, this means that
finset
(which needsmultiset.nodup
) can be defined without needing the material onlist.sublists
andmultiset.powerset
.