[Merged by Bors] - refactor(group_theory/perm/cycle/basic): Consolidate API #17898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
3 tasks
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
Move the `same_cycle` lemmas before the `is_cycle` ones in order to reduce the diff in #17898. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Dec 13, 2022
Vierkantor
approved these changes
Jan 4, 2023
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
The bors queue is currently empty, so I will just try going ahead. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
Reorganise and complete the cycle API: * Previously, `is_cycle` was spelling out the definition of `same_cycle`. Now use it explicitly. * Change binder to semi-implicit in the definition of `is_cycle`. * Add lemmas and iff aliases. * Golf existing proofs using those (mostly invisible from the diff because git decided I am moving the `is_cycle` API) * Improve lemma names, mostly for better dot notation. ## New lemmas * `maps_to.extend_domain` * `surj_on.extend_domain` * `bij_on.extend_domain` * `extend_domain_pow` * `extend_domain_zpow` * `same_cycle.rfl` * `eq.same_cycle` * `same_cycle.conj` * `same_cycle_conj` * `same_cycle_pow_right_iff` * `same_cycle_zpow_right_iff` * `same_cycle.pow_left` * `same_cycle.pow_right` * `same_cycle.zpow_left` * `same_cycle.zpow_left` * `same_cycle.of_pow` * `same_cycle.of_zpow` * `same_cycle_subtype_perm` * `same_cycle.subtype_perm` * `same_cycle_extend_domain` * `is_cycle.conj` * `is_cycle.pow_eq_one_iff'` * `is_cycle.pow_eq_one_iff''` ## Renames * `order_of_is_cycle` → `is_cycle.order_of` * `is_cycle.is_cycle_conj` → `is_cycle.conj` * `is_cycle_of_is_cycle_pow` → `is_cycle.of_pow` * `is_cycle_of_is_cycle_zpow` → `is_cycle.of_zpow` * `same_cycle_cycle` → `is_cycle_iff_same_cycle` * `mem_support_pos_pow_iff_of_lt_order_of` → `support_pow_of_pos_of_lt_order_of` and change the statement to talk about unextensionalised finset equality
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 12, 2023
jcommelin
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganise and complete the cycle API:
is_cyclewas spelling out the definition ofsame_cycle. Now use it explicitly.is_cycle.is_cycleAPI)New lemmas
maps_to.extend_domainsurj_on.extend_domainbij_on.extend_domainextend_domain_powextend_domain_zpowsame_cycle.rfleq.same_cyclesame_cycle.conjsame_cycle_conjsame_cycle_pow_right_iffsame_cycle_zpow_right_iffsame_cycle.pow_leftsame_cycle.pow_rightsame_cycle.zpow_leftsame_cycle.zpow_leftsame_cycle.of_powsame_cycle.of_zpowsame_cycle_subtype_permsame_cycle.subtype_permsame_cycle_extend_domainis_cycle.conjis_cycle.pow_eq_one_iff'is_cycle.pow_eq_one_iff''Renames
order_of_is_cycle→is_cycle.order_ofis_cycle.is_cycle_conj→is_cycle.conjis_cycle_of_is_cycle_pow→is_cycle.of_powis_cycle_of_is_cycle_zpow→is_cycle.of_zpowsame_cycle_cycle→is_cycle_iff_same_cyclemem_support_pos_pow_iff_of_lt_order_of→support_pow_of_pos_of_lt_order_ofand change the statement to talk about unextensionalised finset equality