Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/polynomial/derivative): replace n by C n #17911

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - chore(data/polynomial/derivative): replace n by C n #17911

wants to merge 8 commits into from

Conversation

Multramate
Copy link
Collaborator

@Multramate Multramate commented Dec 12, 2022 •
edited
Loading

Rename derivative_pow lemmas, refactor derivative_X_add_pow slightly, and replace n by C n analogously to #17795

Open in Gitpod

@Multramate Multramate added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Dec 12, 2022
@Multramate Multramate removed the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 13, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 13, 2022
@Multramate Multramate mentioned this pull request Dec 13, 2022
Closed
3 tasks
alreadydone
alreadydone approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also added derivative_X_add_C, derivative_sq, derivative_X_add_C_sq, derivative_X_sub_C, derivative_X_sub_C_sq right? LGTM.

src/data/polynomial/derivative.lean Outdated Show resolved Hide resolved
@alreadydone
Copy link
Collaborator

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@Multramate @alreadydone
Update src/data/polynomial/derivative.lean
18651fe 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
jcommelin
jcommelin approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 19, 2022
bors bot pushed a commit that referenced this pull request Dec 19, 2022
@Multramate
chore(data/polynomial/derivative): replace n by C n (#17911)
bbeb185 
Rename `derivative_pow` lemmas, refactor `derivative_X_add_pow` slightly, and replace `n` by `C n` analogously to #17795
@bors
Copy link

bors bot commented Dec 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/polynomial/derivative): replace n by C n [Merged by Bors] - chore(data/polynomial/derivative): replace n by C n Dec 19, 2022
@bors bors bot closed this Dec 19, 2022
@bors bors bot deleted the derivative_pow branch December 19, 2022 09:05
bors bot pushed a commit that referenced this pull request Feb 10, 2023
@Multramate @alreadydone
feat(algebraic_geometry/elliptic_curve/point): define addition of K-r…
67f92b6 
…ational points (#17194)

- [x] depends on: #17631 
- [x] depends on: #17700
- [x] depends on: #17911 



Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Multramate @alreadydone @jcommelin @leanprover-community-bot-assistant