Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(ci): do not fail when detecting ported files more than 40 commits old #17914

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

The previous action worked by using git diff, but this fails on shallow checkouts. This version hits the github API.


Open in Gitpod

…0 commits old

The previous action worked by using `git diff`, but this fails on shallow checkouts. This version hits the github API.
@eric-wieser eric-wieser changed the title fix(ci): do not fail when adding comments to ported files more than 40 commits old fix(ci): do not fail when detecting ported files more than 40 commits old Dec 12, 2022
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR CI This issue or PR is about continuous integration labels Dec 12, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 12, 2022
bors bot pushed a commit that referenced this pull request Dec 12, 2022
… old (#17914)

The previous action worked by using `git diff`, but this fails on shallow checkouts. This version hits the github API.
@bors
Copy link

bors bot commented Dec 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(ci): do not fail when detecting ported files more than 40 commits old [Merged by Bors] - fix(ci): do not fail when detecting ported files more than 40 commits old Dec 13, 2022
@bors bors bot closed this Dec 13, 2022
@bors bors bot deleted the eric-wieser/fix-ported-warnings branch December 13, 2022 00:40
ocfnash added a commit that referenced this pull request Dec 14, 2022
I want to pick up #17914 which should fix the spurious CI failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI This issue or PR is about continuous integration ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants