[Merged by Bors] - feat(data/set/finite): Align set.to_finset and set.finite.to_finset
#17959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
2 tasks
eric-wieser
approved these changes
Dec 16, 2022
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Dec 16, 2022
eric-wieser
reviewed
Dec 16, 2022
eric-wieser
added
delegated
YaelDillies
removed
the
awaiting-CI
|
Fixed the final lint issues. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
…t` (#17959) Match lemmas about `set.to_finset` and `set.finite.to_finset`. This mostly involves making sure we have all pairs of the form `set.to_finset_whatever`/`set.finite.to_finset_whatever`. Also add a few lemmas and tag existing ones with simp.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
set.to_finset and set.finite.to_finsetset.to_finset and set.finite.to_finset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match lemmas about
set.to_finsetandset.finite.to_finset. This mostly involves making sure we have all pairs of the formset.to_finset_whatever/set.finite.to_finset_whatever.Also add a few lemmas and tag existing ones with simp.