Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/covering) weaken sigma_compact_space to second_countable_topology #17960

Closed
wants to merge 10 commits into from

Conversation

sgouezel
Copy link
Collaborator

Currently, theorems on differentiation of measures require the assumption that the space is sigma compact. However, they all hold under the weaker assumption that the space is second-countable, as shown by this PR.


Open in Gitpod

@sgouezel sgouezel requested a review from a team as a code owner December 15, 2022 15:07
@sgouezel sgouezel added awaiting-review The author would like community review of the PR t-measure-probability Measure theory / Probability theory labels Dec 15, 2022
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, really nice; thanks for doing this.

I wonder if there is a topological condition (implying both sigma compact and second countable) that would unify the two results about existence of a finite spanning
sequence of open sets for a locally finite measure?

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 15, 2022
@sgouezel
Copy link
Collaborator Author

I wonder if there is a topological condition (implying both sigma compact and second countable) that would unify the two results about existence of a finite spanning sequence of open sets for a locally finite measure?

Yes: the fact that any open cover admits a countable subcover. I considered introducing a typeclass for this, but adding several dozens of line to save a small code duplication seemed suboptimal.

@ocfnash
Copy link
Collaborator

ocfnash commented Dec 15, 2022

Yes: the fact that any open cover admits a countable subcover.

Right of course!

I considered introducing a typeclass for this, but adding several dozens of line to save a small code duplication seemed suboptimal.

Agreed.

@urkud
Copy link
Member

urkud commented Dec 15, 2022

@ocfnash I have an abandoned PR that adds this typeclass: #11716.

bors bot pushed a commit that referenced this pull request Dec 15, 2022
…untable_topology (#17960)

Currently, theorems on differentiation of measures require the assumption that the space is sigma compact. However, they all hold under the weaker assumption that the space is second-countable, as shown by this PR.
@sgouezel
Copy link
Collaborator Author

I didn't know this had a name!

@bors
Copy link

bors bot commented Dec 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/covering) weaken sigma_compact_space to second_countable_topology [Merged by Bors] - feat(measure_theory/covering) weaken sigma_compact_space to second_countable_topology Dec 15, 2022
@bors bors bot closed this Dec 15, 2022
@bors bors bot deleted the better_differentiation branch December 15, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants