-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(measure_theory): define Borel hierarchy and reprove cardinality bound on σ-algebras #17972
Conversation
…Union` I define `ω₁` as an ordinal (not as an `out`, cf. `measure_theory.card_measurable_space`). I prove a pair of lemmas using its cofinality. I add a lemma on the cardinality of ordinal-indexed `Union`s in preparation for material on the Borel hierarchy.
…ound on σ-algebras I give an inductive definition of the Borel hierarchy (as suggested by Junyan Xu) and I provide a basic API. This file serves as a refactor of `measure_theory.card_measurable_space` since all the relevant results are proved using this engineering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First bunch of comments, mostly about the use of docstrings.
src/set_theory/ordinal/basic.lean
Outdated
@@ -957,6 +957,13 @@ theorem ord_card_le (o : ordinal) : o.card.ord ≤ o := gc_ord_card.l_u_le _ | |||
|
|||
lemma lt_ord_succ_card (o : ordinal) : o < (succ o.card).ord := lt_ord.2 $ lt_succ _ | |||
|
|||
/-- | |||
The converse of the following lemma is false (take, for instance `i = ω+1` and `κ = ℵ₀`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring is something which shows up as a tooltip when using the lemma. So it should explain the content of the lemma. Additional comments such that the fact that the converse is false are definitely useful, but the first goal is to explain the content of the lemma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has already been reached by the tide. What would be the best course of action now? Either,
- move the change to the point of first use (perhaps with a TODO sign to later fix it), therefore leaving this file unmodified; or
- keep the edit as it stands, and when (if) the changes are approved, create a parallel PR to mathlib4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has already been reached by the tide. What would be the best course of action now? Either,
- move the change to the point of first use (perhaps with a TODO sign to later fix it), therefore leaving this file unmodified
I decided to go this way. I didn't put the TODO sign after all, but I keep a personal record for tidying things up later.
No need to mention previous history Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Saving space as suggested Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Saving space as suggested Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
In particular, an intro section defining the Borel hierarchy in detail.
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review on the first part of the code. I have a lot of minor comments, which is perfectly normal. Could you make sure that you also take these comments into account in the part of the code I haven't reviewed?
Correct spacing Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
≠ is the standard spelling Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Singular namespaces. And spacing Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
- Simplifying closure of proofs. - Style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the Borel hierarchy part yet.
Golfed proof Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com>
…ing ordinal.basic
I give an inductive definition of the Borel hierarchy (as suggested by Junyan Xu) and
I provide a basic API. This file serves as a refactor of
measure_theory.card_measurable_space
since all the relevant results are proved using this engineering.
EDIT: The refactor is going to be part of a new PR as suggested during review.
There are self-contained changes to the set_theory folder that can be reviewed independently.
ω₁
is now an ordinal (not anout
, cf.measure_theory.card_measurable_space
); for this I use the new functionordinal.initial
. I prove a lemma using the cofinality ofω₁
. I add a lemma on the cardinality of ordinal-indexedUnion
s.