Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(measure_theory): define Borel hierarchy and reprove cardinality bound on σ-algebras #17972

Closed
wants to merge 21 commits into from

Conversation

sterraf
Copy link
Collaborator

@sterraf sterraf commented Dec 17, 2022

I give an inductive definition of the Borel hierarchy (as suggested by Junyan Xu) and
I provide a basic API. This file serves as a refactor of measure_theory.card_measurable_space
since all the relevant results are proved using this engineering.
EDIT: The refactor is going to be part of a new PR as suggested during review.

There are self-contained changes to the set_theory folder that can be reviewed independently. ω₁ is now an ordinal (not an out, cf. measure_theory.card_measurable_space); for this I use the new function ordinal.initial. I prove a lemma using the cofinality of ω₁. I add a lemma on the cardinality of ordinal-indexed Unions.


Open in Gitpod

…Union`

I define `ω₁` as an ordinal (not as an `out`, cf. `measure_theory.card_measurable_space`).
I prove a pair of lemmas using its cofinality.
I add a lemma on the cardinality of ordinal-indexed `Union`s in preparation for material on the Borel hierarchy.
@sterraf sterraf added the awaiting-review The author would like community review of the PR label Dec 17, 2022
…ound on σ-algebras

I give an inductive definition of the Borel hierarchy (as suggested by Junyan Xu) and
I provide a basic API. This file serves as a refactor of `measure_theory.card_measurable_space`
since all the relevant results are proved using this engineering.
@sterraf sterraf requested a review from a team as a code owner December 17, 2022 20:52
@sterraf sterraf assigned sterraf and unassigned sterraf Dec 17, 2022
@sterraf sterraf changed the title feat(set_theory): define ω₁ and prove lemma on cardinality of Union feat(measure_theory): define Borel hierarchy and reprove cardinality bound on σ-algebras Dec 18, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First bunch of comments, mostly about the use of docstrings.

src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/ordinal.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/ordinal.lean Outdated Show resolved Hide resolved
@@ -957,6 +957,13 @@ theorem ord_card_le (o : ordinal) : o.card.ord ≤ o := gc_ord_card.l_u_le _

lemma lt_ord_succ_card (o : ordinal) : o < (succ o.card).ord := lt_ord.2 $ lt_succ _

/--
The converse of the following lemma is false (take, for instance `i = ω+1` and `κ = ℵ₀`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring is something which shows up as a tooltip when using the lemma. So it should explain the content of the lemma. Additional comments such that the fact that the converse is false are definitely useful, but the first goal is to explain the content of the lemma.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has already been reached by the tide. What would be the best course of action now? Either,

  • move the change to the point of first use (perhaps with a TODO sign to later fix it), therefore leaving this file unmodified; or
  • keep the edit as it stands, and when (if) the changes are approved, create a parallel PR to mathlib4?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has already been reached by the tide. What would be the best course of action now? Either,

  • move the change to the point of first use (perhaps with a TODO sign to later fix it), therefore leaving this file unmodified

I decided to go this way. I didn't put the TODO sign after all, but I keep a personal record for tidying things up later.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes t-order Order hierarchy and removed awaiting-review The author would like community review of the PR labels Dec 26, 2022
sterraf and others added 5 commits December 26, 2022 15:39
No need to mention previous history

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Saving space as suggested

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Saving space as suggested

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
In particular, an intro section defining the Borel hierarchy in detail.
@sterraf sterraf added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 26, 2022
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 27, 2022
@sterraf sterraf added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR labels Dec 28, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on the first part of the code. I have a lot of minor comments, which is perfectly normal. Could you make sure that you also take these comments into account in the part of the code I haven't reviewed?

src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 7, 2023
sterraf and others added 2 commits January 7, 2023 11:07
Correct spacing

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
≠  is the standard spelling

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/cofinality.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/cofinality.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_hierarchy.lean Outdated Show resolved Hide resolved
sterraf and others added 4 commits January 7, 2023 17:36
Singular namespaces. And spacing

Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
  - Simplifying closure of proofs.
  - Style.
@sterraf sterraf added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 9, 2023
Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the Borel hierarchy part yet.

src/set_theory/cardinal/ordinal.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/ordinal.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/cofinality.lean Outdated Show resolved Hide resolved
src/set_theory/cardinal/cofinality.lean Outdated Show resolved Hide resolved
sterraf and others added 2 commits January 26, 2023 12:39
Golfed proof

Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com>
@semorrison semorrison added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Mar 28, 2023
@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
@semorrison
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants