Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebraic_geometry/elliptic_curve/weierstrass): add disclaimer for coordinate_ring irreducibility #17977

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(algebraic_geometry/elliptic_curve/weierstrass): add disclaimer for coordinate_ring irreducibility #17977

wants to merge 2 commits into from

Conversation

Multramate
Copy link
Collaborator

Also rename coe_inv lemmas to be consistent with those generated by @[simps].

Co-authored-by: Anne Baanen t.baanen@vu.nl

Open in Gitpod

@Multramate Multramate added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebraic-geometry Algebraic geometry t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Dec 19, 2022
@Multramate Multramate requested a review from a team as a code owner December 19, 2022 13:43
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 19, 2022
@Vierkantor Vierkantor self-assigned this Dec 19, 2022
Vierkantor
Vierkantor approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

bors d+

src/algebraic_geometry/elliptic_curve/weierstrass.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 19, 2022

✌️ Multramate can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 19, 2022
@Multramate
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 19, 2022
@Multramate @Vierkantor
chore(algebraic_geometry/elliptic_curve/weierstrass): add disclaimer …
550b585 
…for coordinate_ring irreducibility (#17977)

Also rename `coe_inv` lemmas to be consistent with those generated by `@[simps]`.

Co-authored-by: Anne Baanen <t.baanen@vu.nl>
@bors
Copy link

bors bot commented Dec 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebraic_geometry/elliptic_curve/weierstrass): add disclaimer for coordinate_ring irreducibility [Merged by Bors] - chore(algebraic_geometry/elliptic_curve/weierstrass): add disclaimer for coordinate_ring irreducibility Dec 19, 2022
@bors bors bot closed this Dec 19, 2022
@bors bors bot deleted the weierstrass_curve.coordinate_ring branch December 19, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees

@Vierkantor Vierkantor

Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. t-algebraic-geometry Algebraic geometry t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Multramate @Vierkantor @leanprover-community-bot-assistant