Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/well_approximable): well-approximable numbers and Gallagher's zero-one law #18011

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(number_theory/well_approximable): well-approximable numbers and Gallagher's zero-one law #18011

wants to merge 5 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Dec 24, 2022 •
edited
Loading

@ocfnash ocfnash added WIP Work in progress t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-measure-probability Measure theory / Probability theory labels Dec 24, 2022
@ocfnash ocfnash requested a review from a team as a code owner December 24, 2022 22:52
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 24, 2022
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 26, 2022
@ocfnash ocfnash removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 28, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

PatrickMassot
PatrickMassot reviewed Dec 31, 2022
View reviewed changes
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations Oliver! I left a couple of suggestions, nothing crucial.
bors d+

src/measure_theory/covering/liminf_limsup.lean Outdated Show resolved Hide resolved
src/measure_theory/covering/liminf_limsup.lean Outdated Show resolved Hide resolved
src/measure_theory/covering/liminf_limsup.lean Outdated Show resolved Hide resolved
src/number_theory/well_approximable.lean Show resolved Hide resolved
src/number_theory/well_approximable.lean Outdated Show resolved Hide resolved
src/number_theory/well_approximable.lean Outdated Show resolved Hide resolved
src/number_theory/well_approximable.lean
variables {T : ℝ} [hT : fact (0 < T)]
include hT

local notation a `∤` b := ¬ a ∣ b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this a global notation? Or at least a global localized notation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly it should be but I think this is best left alone till after the port since the notation ∣ (associated with the has_dvd typeclass) is in core.

src/number_theory/well_approximable.lean Show resolved Hide resolved
src/number_theory/well_approximable.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 31, 2022

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 31, 2022
@ocfnash
Copy link
Collaborator Author

ocfnash commented Dec 31, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 31, 2022
bors bot pushed a commit that referenced this pull request Dec 31, 2022
@ocfnash
feat(number_theory/well_approximable): well-approximable numbers and …
ffc3730 
…Gallagher's zero-one law (#18011)
@bors
Copy link

bors bot commented Dec 31, 2022

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat(number_theory/well_approximable): well-approximable numbers and Gallagher's zero-one law [Merged by Bors] - feat(number_theory/well_approximable): well-approximable numbers and Gallagher's zero-one law Dec 31, 2022
@bors bors bot closed this Dec 31, 2022
@bors bors bot deleted the ocfnash/gallagher_thm branch December 31, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocfnash @mathlib-dependent-issues-bot @PatrickMassot @leanprover-community-bot-assistant